support in-place update operation for hnsw #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ShawnShawnYou
commented
Dec 9, 2024
•
ShawnShawnYou
commented
- support in-place update operation for hnsw Support in-place update #225
ShawnShawnYou
requested review from
inabao,
wxyucs,
LHT129 and
jiaweizone
as code owners
inabao
reviewed
Dec 16, 2024
tests/test_index_old.cpp
Outdated
| @@ -637,6 +637,90 @@ TEST_CASE("remove vectors from the index", "[ft][index]") { | |||
| } | |||
| } | |||
|
|
|||
| TEST_CASE("update vectors from the index", "[ft][index]") { | |||
There was a problem hiding this comment.
add thread-safe testing for hnsw
ShawnShawnYou
force-pushed
the
support-update-fresh-hnsw
branch
2 times, most recently
from
7b2ac3e to
9bce756
Compare
LHT129
requested changes
Dec 23, 2024
jiaweizone
reviewed
Dec 23, 2024
src/algorithm/hnswlib/hnswalg.cpp
Outdated
| if (iter == label_lookup_.end()) { | ||
| throw std::runtime_error("no label in HNSW"); | ||
| } else { | ||
| internal_id = iter->second; |
There was a problem hiding this comment.
merge internal_id define to here
InnerIdType internal_id = iter->second;
src/algorithm/hnswlib/hnswalg.cpp
Outdated
| std::unique_lock<std::mutex> lock(global_); | ||
| auto iter = label_lookup_.find(label); | ||
| if (iter == label_lookup_.end()) { | ||
| throw std::runtime_error("no label in HNSW"); |
There was a problem hiding this comment.
minor: add the label id content to error message ?
src/index/hnsw.cpp
Outdated
| } | ||
|
|
||
| try { | ||
| std::unique_lock lock(rw_mutex_); |
There was a problem hiding this comment.
the lock is not necessary ？
ShawnShawnYou
force-pushed
the
support-update-fresh-hnsw
branch
from
9bce756 to
5bc7f48
Compare
ShawnShawnYou
force-pushed
the
support-update-fresh-hnsw
branch
from
b67a25d to
7b01e1f
Compare
Signed-off-by: zhongxiaoyao.zxy <[email protected]>
ShawnShawnYou
force-pushed
the
support-update-fresh-hnsw
branch
from
7b01e1f to
c81a417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.