define the interface for the "pyramid" #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2024 11:31
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
jiaweizone
reviewed
Dec 1, 2024
| @@ -30,7 +30,8 @@ | |||
| namespace vsag { | |||
|
|
|||
| class DatasetImpl : public Dataset { | |||
| using var = std::variant<int64_t, const float*, const int8_t*, const int64_t*>; | |||
| using var = | |||
| std::variant<int64_t, const float*, const int8_t*, const int64_t*, const std::string*>; | |||
There was a problem hiding this comment.
Could you please add the field comments?
There was a problem hiding this comment.
The explanation of these fields can be found at the interface.
added 2 commits
December 3, 2024 16:01
Signed-off-by: jinjiabao.jjb <[email protected]>
jiaweizone
reviewed
Dec 15, 2024
Signed-off-by: jinjiabao.jjb <[email protected]>
LHT129
requested changes
Dec 17, 2024
examples/cpp/simple_pyramid.cpp
Outdated
|
|
||
| std::mt19937 rng; | ||
| rng.seed(47); | ||
| std::uniform_real_distribution<> distrib_real; |
added 2 commits
December 17, 2024 19:34
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#166