add retry behavior for aws collector

[j3ttt]

Thank you for your contribution to CloudRec!

What About:

• Server (java)
• Collector (go)
• Rule (opa)

Description:

Try to fix the 'exceeded maximum number of attempts' api limit error.
Using Adaptive retry mode for AWS client.

Summary by Sourcery

Enhancements:

• Configure AWS Go SDK to use adaptive retry mode in the collector buildConfigWithRegion

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the AWS collector's resilience by configuring the AWS SDK with adaptive retry logic and provides a template for custom retry settings, along with minor code formatting adjustments.

Class diagram for updated AWS Services struct and config builder

classDiagram
class Services {
  Region string
  EC2 *ec2.Client
  IAM *iam.Client
  S3 *s3.Client
}
class buildConfigWithRegion {
  +aws.Config
  +error
}
Services --> buildConfigWithRegion

Loading

Flow diagram for AWS config creation with adaptive retry

flowchart TD
    A["Start config creation"] --> B["Set region, credentials, and logging"]
    B --> C["Set retry mode to Adaptive"]
    C --> D["Return aws.Config"]

Loading

File-Level Changes

Change	Details	Files
Enable adaptive retry mode in AWS client configuration	Added config.WithRetryMode(aws.RetryModeAdaptive) to buildConfigWithRegion Included commented template for custom standard retryer configuration	collector/aws/collector/services.go
Align struct field definitions for Services	Adjusted spacing for Region field in Services struct	collector/aws/collector/services.go

Possibly linked issues

• #N/A: PR adds adaptive retry to AWS collector to fix 'exceeded maximum attempts' API limit error, directly addressing the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @j3ttt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an adaptive retry mechanism for AWS SDK clients within the Go-based collector. The primary goal is to enhance the collector's robustness by automatically retrying AWS API calls that fail due to rate limiting or other transient issues, thereby preventing 'exceeded maximum number of attempts' errors and ensuring more reliable data collection.

Highlights

• AWS SDK Retry Mechanism: Implemented "Adaptive" retry mode for AWS SDK clients to mitigate 'exceeded maximum number of attempts' API limit errors, enhancing the collector's resilience.
• Configuration Update: Modified the buildConfigWithRegion function in services.go to incorporate the new adaptive retry configuration for AWS clients.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request correctly implements an adaptive retry mode for the AWS client, which should help mitigate API rate limiting errors. The change is a good improvement. However, there is a block of commented-out code that appears to be from experimentation and should be removed to maintain code clarity.