fix!: improve detect algorithm, detect runs null when dismatch, fix #9
#10
Conversation
antfu
changed the title
detect runs null when dismatch, fix #9
| const lockPath = await findUp(Object.keys(LOCKS), { cwd }) | ||
| let packageJsonPath: string | undefined | ||
| export interface DetectResult { | ||
| agent: Agent |
There was a problem hiding this comment.
a bit unrelated to the issue being solved here, but I though I'd mention that the other thing that might be helpful here is to return the package manager. most usages I've seen are just looking for that and so always end up having to do agent.split('@')[0]
There was a problem hiding this comment.
We can do another PR to separate that fields
| for (const directory of lookup(cwd)) { | ||
| // Look up for lock files | ||
| for (const lock of Object.keys(LOCKS)) { | ||
| if (await fileExists(path.join(directory, lock))) { |
There was a problem hiding this comment.
I'm not sure if this would solve the reported issue. I understood the issue to be something like:
rootproj
|-package.json
|-pnpm.lock
|-packages
|- subproj
|- package.json (contains packageManager field)
So I think we'd need to check for the presence of the packageManager field independently of checking for the lockfile
There was a problem hiding this comment.
Yeah that's the new behaviour. Instead of findUp separately for locks and packageManager field, now we check both in each directory up (the lookup function) and get the closest match
Change to scan the lock and package.json at the same time and return the first match. Ideally it would be sightly more efficient as the lookup will only happen once now