Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoload Patchwork.php in Composer configuration #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RubieV
Copy link

@RubieV RubieV commented Aug 23, 2016

Composer nor autoloading seems to not be included in the tests, adding tests around this change might be beneficial.

Composer nor autoloading seems to not be included in the tests, adding tests around this change might be beneficial.
@antecedent
Copy link
Owner

The manual loading policy is deliberate.

Patchwork is first and foremost a testing tool, and tests often reside in the same codebase as the system-under-test. Add the fact that Patchwork slows things down considerably, and now we have a problem: we have to selectively enable Patchwork during testing only, or else we default to negatively impacting the production performance.

But let me know if you have an decent solution for the latter :)

@RubieV
Copy link
Author

RubieV commented Aug 23, 2016

I assume you will add a dev-dependency on Patchwork in Composer if you only want Patchwork during tests.

Since changing this behavior will have unexpected results for integrations that do manual loading, I would propose a (minor) version increment.

@szepeviktor szepeviktor mentioned this pull request Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants