Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tree-select supports onPopupScroll #48636

Merged
merged 6 commits into from Apr 28, 2024

Conversation

wanpan11
Copy link
Contributor

@wanpan11 wanpan11 commented Apr 25, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48528

💡 Background and solution

tree-select supports onPopupScroll

📝 Changelog

Language Changelog
🇺🇸 English tree-select supports onPopupScroll
🇨🇳 Chinese tree-select 支持 onPopScroll

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 25, 2024

👁 Visual Regression Report for PR #48636 Passed ✅

🎯 Target branch: feature (97b8913)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

socket-security bot commented Apr 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ant-design/[email protected] environment 0 399 kB madccc
npm/@ant-design/[email protected] None 0 30.9 kB zombiej
npm/@ant-design/[email protected] filesystem 0 65.7 kB madccc
npm/@antv/[email protected] None 0 7.99 MB iaaron
npm/@babel/[email protected] None 0 30.2 kB nicolo-ribaudo
npm/@biomejs/[email protected] shell 0 133 kB dominionl
npm/@codesandbox/[email protected] eval 0 1.16 MB danilowoz
npm/@dnd-kit/[email protected] environment 0 1.05 MB clauderic
npm/@dnd-kit/[email protected] environment 0 48.1 kB clauderic
npm/@dnd-kit/[email protected] environment 0 233 kB clauderic
npm/@dnd-kit/[email protected] environment 0 88.5 kB clauderic
npm/@emotion/[email protected] environment 0 583 kB emotion-release-bot
npm/@emotion/[email protected] environment 0 48.7 kB emotion-release-bot
npm/@ianvs/[email protected] environment, unsafe 0 109 kB ianvs
npm/@madccc/[email protected] None 0 19 kB madccc
npm/@microflash/[email protected] None 0 6.79 kB naiyer
npm/@npmcli/[email protected] environment 0 18.2 kB npm-cli-ops
npm/@octokit/[email protected] None 0 9.96 kB octokitbot
npm/@qixian.cs/[email protected] network 0 19.5 kB chenshuai2144
npm/@size-limit/[email protected] None 0 3.43 kB ai
npm/@stackblitz/[email protected] None 0 180 kB fvsch
npm/@testing-library/[email protected] environment 0 2.42 MB testing-library-bot
npm/@testing-library/[email protected] None 0 266 kB testing-library-bot
npm/@testing-library/[email protected] environment 0 4.3 MB testing-library-bot
npm/@testing-library/[email protected] None 0 435 kB testing-library-bot
npm/@types/[email protected] None 0 24.7 kB types
npm/@types/[email protected] None 0 42.2 kB types
npm/@types/[email protected] None 0 12.9 kB types
npm/@types/[email protected] None 0 36.8 kB types
npm/@types/[email protected] None 0 8.85 kB types
npm/@types/[email protected] None 0 4.58 kB types
npm/@types/[email protected] None 0 73.6 kB types
npm/@types/[email protected] None 0 2.77 kB types
npm/@types/[email protected] None 0 6.62 kB types
npm/@types/[email protected] None 0 6.09 kB types
npm/@types/[email protected] None 0 9.68 kB types
npm/@types/[email protected] None 0 78.7 kB types
npm/@types/[email protected] None 0 1.12 MB types
npm/@types/[email protected] None 0 21.9 kB types
npm/@types/[email protected] None 0 862 kB types
npm/@types/[email protected] None 0 6.27 kB types
npm/@types/[email protected] None 0 2.03 MB types
npm/@types/[email protected] None 0 4.83 kB types
npm/@types/[email protected] None 0 1.7 kB types
npm/@types/[email protected] None 0 7.87 kB types
npm/@types/[email protected] None 0 5.45 kB types
npm/@types/[email protected] None 0 19.2 kB types
npm/@types/[email protected] None 0 6.51 kB types
npm/@types/[email protected] None 0 7.34 kB types
npm/@types/[email protected] None 0 4.36 kB types
npm/@types/[email protected] None 0 34.9 kB types
npm/@types/[email protected] None 0 5.53 kB types
npm/@types/[email protected] None 0 7.1 kB types
npm/@types/[email protected] None 0 433 kB types
npm/@types/[email protected] None 0 23.3 kB types
npm/@types/[email protected] None 0 8.22 kB types
npm/@types/[email protected] None 0 30.8 kB types
npm/@types/[email protected] None 0 6.48 kB types
npm/@types/[email protected] None 0 2.71 kB types
npm/@typescript-eslint/[email protected] None 0 2.69 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 18 kB jameshenry
npm/[email protected] filesystem 0 104 kB cthackers
npm/[email protected] filesystem 0 2.72 MB fengmk2
npm/[email protected] None 0 49.7 kB nanxiaobei
npm/[email protected] environment 0 188 kB arvinxx
npm/[email protected] None 0 1.22 MB madccc
npm/[email protected] network 0 1.84 MB jasonsaayman
npm/[email protected] None 0 558 kB feedic
npm/[email protected] None 0 10.5 kB theron
npm/[email protected] None 0 62.2 kB andidittrich
npm/[email protected] environment 0 29.1 kB kentcdodds
npm/[email protected] network 0 88.1 kB lquixada
npm/[email protected] None 0 778 B ehsalazar
npm/[email protected] filesystem 0 8.91 kB benjycui
npm/[email protected] None 0 38.8 kB wxh16144
npm/[email protected] environment, eval, filesystem 0 2.94 MB peachscript
npm/[email protected] None 0 34.3 kB hirokiosame
npm/[email protected] None 0 81.7 kB ljharb
npm/[email protected] None 0 20.8 kB lydell
npm/[email protected] None 0 45.1 kB jounqin
npm/[email protected] filesystem +1 56.3 kB amilajack
npm/[email protected] filesystem, unsafe Transitive: environment +1 1.26 MB ljharb
npm/[email protected] filesystem 0 314 kB simenb
npm/[email protected] None 0 739 kB ljharb
npm/[email protected] filesystem 0 320 kB idok
npm/[email protected] None 0 30.5 kB eslintbot
npm/[email protected] environment 0 118 kB react-bot
npm/[email protected] filesystem +1 915 kB ljharb
npm/[email protected] None 0 677 kB sindresorhus
npm/[email protected] environment, filesystem +1 3.04 MB eslintbot
npm/[email protected] filesystem 0 96.7 kB mrmlnc
npm/[email protected] None 0 12.4 kB camsong
npm/[email protected] None +1 59.6 kB ryanzim
npm/[email protected] filesystem, shell 0 39.9 kB tschaub
npm/[email protected] Transitive: environment +1 895 kB isaacs
npm/[email protected] network 0 1.87 MB arvinxx
npm/[email protected] environment, filesystem, network 0 124 kB thornjad
npm/[email protected] environment, filesystem, shell 0 3.61 kB typicode
npm/[email protected] None 0 8.38 kB keyanzhang
npm/[email protected] environment 0 623 kB mweststrate
npm/[email protected] None +1 93 kB sboudrias
npm/[email protected] None 0 3.81 kB sibiraj-s
npm/[email protected] Transitive: network +1 169 kB mattandrews
npm/[email protected] None 0 21 kB nickcolley
npm/[email protected] None 0 112 kB atool
npm/[email protected] None 0 9.21 kB simenb
npm/[email protected] unsafe 0 9.37 kB simenb
npm/[email protected] environment, filesystem, shell 0 84.9 kB amexopensource
npm/[email protected] None 0 3.7 kB neoziro
npm/[email protected] None 0 5.01 kB simenb
npm/[email protected] None 0 1.25 MB timmywil
npm/[email protected] eval, filesystem, network, shell, unsafe 0 3.11 MB domenic
npm/[email protected] None 0 21.2 kB benjycui
npm/[email protected] None 0 28.3 kB benjycui
npm/[email protected] Transitive: environment, filesystem, shell +2 340 kB okonet
npm/[email protected] None 0 1.41 MB bnjmnt4n
npm/[email protected] None 0 1.34 MB 6tail
npm/[email protected] None 0 176 kB pieroxy
npm/[email protected] None 0 13.8 kB boblauer
npm/[email protected] network 0 107 kB node-fetch-bot
npm/[email protected] environment, filesystem, network, shell +1 5.69 MB mikaelb
npm/[email protected] environment 0 36.5 kB zombiej
npm/[email protected] environment 0 39.7 kB afc163
npm/[email protected] environment 0 337 kB zombiej
npm/[email protected] environment 0 156 kB afc163
npm/[email protected] None 0 48.3 kB zombiej
npm/[email protected] None 0 20.5 kB afc163
npm/[email protected] environment 0 398 kB afc163
npm/[email protected] environment 0 166 kB afc163
npm/[email protected] environment 0 61.9 kB madccc
npm/[email protected] None 0 52.3 kB zombiej
npm/[email protected] environment 0 162 kB zombiej
npm/[email protected] environment 0 371 kB zombiej
npm/[email protected] None 0 66.7 kB zombiej
npm/[email protected] environment +1 257 kB zombiej
npm/[email protected] environment 0 4.51 MB react-bot
npm/[email protected] environment 0 318 kB react-bot
npm/[email protected] None 0 44.8 kB stipsan
npm/[email protected] None 0 83.1 kB niksy

View full report↗︎

@li-jia-nan
Copy link
Member

新特性提交到 feature 分支吧

Copy link

codesandbox-ci bot commented Apr 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@wanpan11 wanpan11 changed the base branch from master to feature April 25, 2024 16:11
Copy link
Contributor

Hi @wanpan11. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@li-jia-nan
Copy link
Member

master 的提交带过来了,需要清理一下 commit,只保留自己的改动就好了

@wanpan11
Copy link
Contributor Author

master 的提交带过来了,需要清理一下 commit,只保留自己的改动就好了

好的

@wanpan11
Copy link
Contributor Author

@li-jia-nan 佬 这个 ci 报错 我需要干撒不

@li-jia-nan
Copy link
Member

li-jia-nan commented Apr 26, 2024

@li-jia-nan 佬 这个 ci 报错 我需要干撒不

看起来不是这个 PR 导致的,不过得开个新 PR 修一下,感觉是哪个库更新了,求助一下大佬 @zombieJ @MadCcc

@wanpan11
Copy link
Contributor Author

不知道是不是版本的问题,我本地 18.2 是通过了的。
image

@li-jia-nan
Copy link
Member

我来看一下吧

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97b8913) to head (b4aebe9).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #48636   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12981     12981           
  Branches      3403      3403           
=========================================
  Hits         12981     12981           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MadCcc
MadCcc previously approved these changes Apr 28, 2024
Copy link

socket-security bot commented Apr 28, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@ant-design/[email protected], npm/@biomejs/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@wanpan11
Copy link
Contributor Author

@SocketSecurity ignore npm/@ant-design/[email protected]
@SocketSecurity ignore npm/@biomejs/[email protected]

1 similar comment
@li-jia-nan
Copy link
Member

@SocketSecurity ignore npm/@ant-design/[email protected]
@SocketSecurity ignore npm/@biomejs/[email protected]

@li-jia-nan li-jia-nan merged commit 4020f65 into ant-design:feature Apr 28, 2024
60 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@wanpan11 wanpan11 deleted the rc-tree-select branch April 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants