Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ajust the input border style in validation #48616

Merged
merged 2 commits into from Apr 28, 2024

Conversation

nova1751
Copy link
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#48532

💡 Background and solution

Related to PR #46435. The Input component should have the same border style as other form components, I make a little ajustment to keep the style consistent.

📝 Changelog

Language Changelog
🇺🇸 English Ajust the Input component border style in form validation when disabled
🇨🇳 Chinese 调整了Input组件在禁用的时候在表单校验的时候的边框颜色

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

👁 Visual Regression Report for PR #48616 Failed ❌

🎯 Target branch: master (533c855)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
form-disabled-input-debug.compact.png form-disabled-input-debug.compact.png form-disabled-input-debug.compact.png form-disabled-input-debug.compact.png
form-disabled-input-debug.compact.png form-disabled-input-debug.compact.png form-disabled-input-debug.compact.css-var.png form-disabled-input-debug.compact.css-var.png
form-disabled-input-debug.dark.png form-disabled-input-debug.dark.png form-disabled-input-debug.dark.png form-disabled-input-debug.dark.png
form-disabled-input-debug.dark.png form-disabled-input-debug.dark.png form-disabled-input-debug.dark.css-var.png form-disabled-input-debug.dark.css-var.png
form-disabled-input-debug.default.png form-disabled-input-debug.default.png form-disabled-input-debug.default.png form-disabled-input-debug.default.png
form-disabled-input-debug.default.png form-disabled-input-debug.default.png form-disabled-input-debug.default.css-var.png form-disabled-input-debug.default.css-var.png

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Preview is ready

@nova1751
Copy link
Contributor Author

nova1751 commented Apr 25, 2024

After change:

Input.-.Ant.Design.19.-.-.Microsoft.Edge.2024-04-25.13-47-12.mp4

Copy link

codesandbox-ci bot commented Apr 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (decfac3) to head (d86cd0e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48616   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12946     12946           
  Branches      3382      3382           
=========================================
  Hits         12946     12946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 27, 2024

加用例覆盖吧

@nova1751
Copy link
Contributor Author

加用例覆盖吧

意思是这个也添加一个测试用例吗?

@MadCcc MadCcc merged commit f799219 into ant-design:master Apr 28, 2024
60 of 61 checks passed
li-jia-nan added a commit that referenced this pull request Apr 28, 2024
@vagusX vagusX mentioned this pull request Apr 28, 2024
@afc163
Copy link
Member

afc163 commented Apr 29, 2024

我怎么感觉不加红色边框才是对的。

@nova1751
Copy link
Contributor Author

我怎么感觉不加红色边框才是对的。

我是觉得既然表单校验触发的提示文字都显示了,输入框border样式还是保持一致比较好。🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants