Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/droprdown accessibility #48499

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Feat/droprdown accessibility #48499

wants to merge 8 commits into from

Commits on Apr 15, 2024

  1. feat: add needed aria attributes to 'menu' and 'dropdownTrigger'

    @KirilCycle
    KirilCycle committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2e2b3e8 View commit details
    Browse the repository at this point in the history

  2. feat: aria-expanded value depednds on menu visibility

    @KirilCycle
    KirilCycle committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    55aaebf View commit details
    Browse the repository at this point in the history

  3. open dropdown menu on 'space'and 'enter' keypress

    @KirilCycle
    KirilCycle committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d5be51b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. fix: dropdown menu on first item focus works with a tag inside list item

    @KirilCycle
    KirilCycle committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f920a09 View commit details
    Browse the repository at this point in the history

  2. fix: make 'menuLabel' required & remove temType='button' from'Interna… 

    …lMenu'
    @KirilCycle
    KirilCycle committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bdfc21a View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. fix: remove menu ref & use 'onInnerOpenChange' to open the menu on ke… 

    …ypress
    @KirilCycle
    KirilCycle committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c246375 View commit details
    Browse the repository at this point in the history

  2. fix: use keyDown event instead of onFocus to open menu

    @KirilCycle
    KirilCycle committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    223f5cb View commit details
    Browse the repository at this point in the history

  3. fix: focus will move to last focused item

    @KirilCycle
    KirilCycle committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c4bf6bf View commit details
    Browse the repository at this point in the history