feat: support mentions onece delete #48389
Conversation
|
|
👁 Visual Regression Report for PR #48389 Failed ❌
Check Full Report for details |
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature #48389 +/- ##
===========================================
- Coverage 100.00% 99.93% -0.07%
===========================================
Files 744 744
Lines 12887 12925 +38
Branches 3381 3395 +14
===========================================
+ Hits 12887 12916 +29
- Misses 0 9 +9 ☔ View full report in Codecov by Sentry. |
|
新增一个demo吧？ |
| {...restProps} | ||
| filterOption={mentionsfilterOption} | ||
| onKeyDown={onKeyDown} |
There was a problem hiding this comment.
事件丢了，应该还需要透一下 props. onKeyDown?.(event)
| @@ -45,6 +46,7 @@ export interface MentionProps extends Omit<RcMentionsProps, 'suffix'> { | |||
| status?: InputStatus; | |||
| options?: MentionsOptionProps[]; | |||
| popupClassName?: string; | |||
| itemOnceDelete?: boolean; | |||
There was a problem hiding this comment.
这个 prop 不符合 antd 的 naming standard，可以先看看现有的 API 命名有没有可以复用的
components/mentions/index.tsx
Outdated
| status: customStatus, | ||
| allowClear = false, | ||
| popupClassName, | ||
| style, | ||
| variant: customVariant, | ||
| ...restProps | ||
| } = props; | ||
| const [data, setData] = React.useState<string>(props.value ?? props.defaultValue ?? ''); |
There was a problem hiding this comment.
useState 参数只有初始化会生效，不会同步 value，这么写不受控
components/mentions/index.tsx
Outdated
| const onKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => { | ||
| if (e.keyCode === KeyCode.BACKSPACE && itemOnceDelete) { | ||
| if (data) { | ||
| setData(data.split('@').slice(0, -1).join('@')); |
There was a problem hiding this comment.
@ 可以自定义，不能写死 @。而且这个逻辑没考虑光标位置，行为是不正确的：
非 mention 对象不应该被删除
删除的 mention 对象不正确
|
还有一个问题：输入@然后输入不是options里面的值， |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#47968
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge