feat: add styles props to support Badge wrapper style #48169
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #48169 Failed ❌
Check Full Report for details |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 744 744
Lines 12896 12896
Branches 3382 3382
=========================================
Hits 12896 12896 ☔ View full report in Codecov by Sentry. |
|
|
li-jia-nan
reviewed
Apr 3, 2024
|
文档&测试用例需要补一下 |
li-jia-nan
reviewed
Apr 4, 2024
| <div>custom styles</div> | ||
| </Badge.Ribbon>, | ||
| ); | ||
| expect(container).toMatchSnapshot(); |
There was a problem hiding this comment.
这里不用留快照，用 toHaveStyle 断言就好了，参考其它地方
components/badge/index.zh-CN.md
Outdated
| @@ -63,6 +63,12 @@ group: 数据展示 | |||
| | placement | 缎带的位置，`start` 和 `end` 随文字方向（RTL 或 LTR）变动 | `start` \| `end` | `end` | | | |||
| | text | 缎带中填入的内容 | ReactNode | - | | | |||
|
|
|||
| ### `styles` 属性 | |||
|
|
|||
| | 名称 | 说明 | | |||
There was a problem hiding this comment.
加上默认值和版本，另外要在 Badge.Ribbon 那一栏加上 styles
li-jia-nan
reviewed
Apr 4, 2024
|
|
||
| | Property | Description | Version | | ||
| | -------- | ------------------------------------- | ------- | | ||
| | body | The style of Ribbon Wrapper Container | 5.16.0 | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#48089
💡 Background and solution
Can't set wrapper of Badge Ribbon's style
Although we can currently set the style of
Badge.Ribbon, the style is applied to the inner element of the wrapper, not the wrapper itself.📝 Changelog
☑️ Self-Check before Merge