fix: When a wireframe token is present, adapt the style of the connect-modal accordingly. #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
这里边距不太对，离得太近了，参考下 antd 的距离。 另外在 ConnectModal 里面添加一个对应的 Demo。 |
🦋 Changeset detectedLatest commit: d63eb7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| group: UI Components | ||
| cover: https://mdn.alipayobjects.com/huamei_mutawc/afts/img/A*mUC3SYLpq0AAAAAAAAAAAAAADlrGAQ/original | ||
| coverDark: https://mdn.alipayobjects.com/huamei_mutawc/afts/img/A*dmHOSI_kdd0AAAAAAAAAAAAADlrGAQ/original | ||
| c--- nav: Components group: UI Components cover: https://mdn.alipayobjects.com/huamei_mutawc/afts/img/A*mUC3SYLpq0AAAAAAAAAAAAAADlrGAQ/original coverDark: https://mdn.alipayobjects.com/huamei_mutawc/afts/img/A*dmHOSI_kdd0AAAAAAAAAAAAADlrGAQ/original |
| @@ -92,6 +95,8 @@ const getThemeStyle = (token: ConnectModalToken): CSSInterpolation => { | |||
| [`${componentCls}-header`]: { | |||
| paddingInline: token.paddingMD, | |||
| height: 30, | |||
| borderBlockEnd: token.wireframe ? '1px solid rgba(0, 0, 0, 0.06)' : 'none', | |||
There was a problem hiding this comment.
1px solid rgba(0, 0, 0, 0.06) 这个应该要换成使用 ant design 的 token 看看是不是 colorPrimaryBorder 这个，或者有更合适的。
| @@ -92,6 +95,8 @@ const getThemeStyle = (token: ConnectModalToken): CSSInterpolation => { | |||
| [`${componentCls}-header`]: { | |||
| paddingInline: token.paddingMD, | |||
| height: 30, | |||
| borderBlockEnd: token.wireframe ? '1px solid rgba(0, 0, 0, 0.06)' : 'none', | |||
| paddingBlockEnd: token.wireframe ? '16px' : 0, | |||
There was a problem hiding this comment.
padding 的置也应该用 antd 的 token，看看能不能用 padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
💡 Background and solution
🔗 Related issue link
#1118