Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iconFontTypes to get all iconfont types #463

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrlmx
Copy link

@mrlmx mrlmx commented Feb 25, 2021

use fetch to load scriptUrl and match all iconfont types

@mrlmx
Copy link
Author

mrlmx commented Mar 8, 2021

@afc163 Hi,偏右大大,可以帮忙看看这段代码么。

主要是为了方便的获取当前 iconfont 链接中的所有 icon,在项目中,可以通过此方法,展示一个 icon 列表,方便筛选 icon。

@afc163
Copy link
Member

afc163 commented Aug 16, 2021

/rebase

@mrlmx
Copy link
Author

mrlmx commented Aug 17, 2021

/rebase

@afc163 Hi,请问一下 /rebase 是什么意思?😂

  • git rebase 吗?
  • 需要我做什么吗?

@mrlmx
Copy link
Author

mrlmx commented Aug 17, 2021

我明白了, /rebase 应该是设置的任务快捷指令。

不过我好像犯了一个错误,就是直接在 master 上提交的。导致 rebase 的时候失败了。

Base branch for PR #492 is master
+ git fetch origin master
From https://github.com/ant-design/ant-design-icons
 * branch              master     -> FETCH_HEAD
+ git fetch fork master
From https://github.com/SoYoung210/ant-design-icons
 * branch              master     -> FETCH_HEAD
 * [new branch]        master     -> fork/master
+ git checkout -b master fork/master
fatal: A branch named 'master' already exists.

这种场景下,是要我单独切个分支提交之后,再重新发起一个 pr 么

@afc163
Copy link
Member

afc163 commented Aug 17, 2021

你可以手动 rebase 一下源仓库远程 master,再 push --force。

use fetch to load scriptUrl and match all iconfont types
@mrlmx
Copy link
Author

mrlmx commented Aug 17, 2021

你可以手动 rebase 一下源仓库远程 master,再 push --force。

已完成 😁

@afc163
Copy link
Member

afc163 commented Aug 18, 2021

图片

修一下。

@mrlmx
Copy link
Author

mrlmx commented Aug 19, 2021

图片

修一下。

已修复

@afc163
Copy link
Member

afc163 commented Aug 19, 2021

来个测试用例?

@mrlmx
Copy link
Author

mrlmx commented Aug 19, 2021

来个测试用例?

ok,我抽空完善一下 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants