-
Notifications
You must be signed in to change notification settings - Fork 8
docs: deprecating a library #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, @RobPasMue. Just left some minor suggestions.
Co-authored-by: Kerry McAdams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this guide line @RobPasMue, I left minor comments
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the content is clear for the PyAnsys developers and for the PyAnsys Core team.
Points blocking have been left as they were after internal discussion
* docs: deprecating a library * docs: missing explanation * fix: vale issues * fix: pre-commit * Update doc/source/how-to/deprecating.rst * fix: removing ref * fix: remove line * Apply suggestions from code review Co-authored-by: Kerry McAdams <[email protected]> * Apply suggestions from code review Co-authored-by: Sébastien Morais <[email protected]> * Apply suggestions from code review * Update doc/source/how-to/deprecating.rst Co-authored-by: Sébastien Morais <[email protected]> * docs: adding documentation banner --------- Co-authored-by: Kerry McAdams <[email protected]> Co-authored-by: Sébastien Morais <[email protected]>
As title says - this documentation shows how to properly deprecate a library and the tasks involved on the @ansys/pyansys-core team side