Feature: Add Support for Firewall [Interface] Groups

[jiuka]

Link to API

https://docs.opnsense.org/development/api/core/firewall.html#id7

Description

It would be nice to setup/manage the [Interface] Groups with Ansible

[jiuka]

What would the preferred name for this module be? To follow the example given by rule and aliase and source_nat it should be named group. However this would be a very generic term which could lead to collisions with system user groups. Any preferences?

[ansibleguy]

Nice :D

Have not even had time to look into the new firewall features. Will give it a look the next few days.

I would name it something like rule_interface_group and add an module-alias rule_if_group as the groups are only related to firewall-rules and group interfaces.

[ansibleguy]

Greetings!

Just looked into that OPNSense feature - very nice to have.

Fixes:

• The docs-link in the first line of the docs should be unique. Maybe something like rule_if_group
• Is there a reason why you added the device alias? Did not find any reference to it.
• Please add the ints and interfaces aliases to the members argument
• Please add the seq alias to the sequence argument
• If the tests work - enable them by adding it to the test.sh

[jiuka]

• The docs-link has been changed
• The device alias has been removed as it was a copy&past artifact
• Other argument aliases have been added.
• I now got the tests working and added it to the test.sh too.

[ansibleguy]

Looks good!

Seems we have a lint error and I can't push to your branch - please fix it so we can continue to merge:
plugins/modules/list.py:26:0: C0301: Line too long (128/120) (line-too-long)

[ansibleguy]

Found an issue with the test.
On the test-box the only the interfaces 'lan' and 'opt1' exist.

When changing the interface of test opn_fail1 to some random name like abc and setting the other ones to lan they seem to work.
We had a similar problem with the gateway tests where we allowed for an override via env-vars in case some dev wants to run them manually.

[ansibleguy]

Will merge and fix it myself afterwards.

Thank you for your contribution!

[ansibleguy]

FYI: ee01592