fix minor issue in ids_policy_rule

ansibleguy · Jul 29, 2024 · d58864f · d58864f
1 parent d6f9f89
commit d58864f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/plugins/module_utils/main/ids_policy_rule.py b/plugins/module_utils/main/ids_policy_rule.py
@@ -39,6 +39,7 @@ def __init__(self, module: AnsibleModule, result: dict, session: Session = None)
         self.exists = False
 
     def check(self) -> None:
+        self.r['diff'] =  {'before': {}, 'after': {}}
         self._search_call()
         self.r['diff']['after'] = self.b.build_diff(data=self.p)
         self.r['changed'] = self.r['diff']['before'] != self.r['diff']['after']
@@ -60,5 +61,6 @@ def _search_call(self) -> list:
                     self.rule['enabled'] = is_true(rule['enabled'])
                     self.rule['action'] = rule['action'].lower()
                     self.r['diff']['before'] = self.rule
+                    break
 
         return existing
diff --git a/plugins/modules/ids_policy_rule.py b/plugins/modules/ids_policy_rule.py
@@ -16,6 +16,7 @@
     from ansible_collections.ansibleguy.opnsense.plugins.module_utils.defaults.main import \
         OPN_MOD_ARGS, STATE_MOD_ARG, RELOAD_MOD_ARG
     from ansible_collections.ansibleguy.opnsense.plugins.module_utils.main.ids_policy_rule import Rule
+    from ansible_collections.ansibleguy.opnsense.plugins.module_utils.helper.main import diff_remove_empty
 
 except MODULE_EXCEPTIONS:
     module_dependency_error()
@@ -55,6 +56,8 @@ def run_module():
     )
 
     module_wrapper(Rule(module=module, result=result))
+
+    result['diff'] = diff_remove_empty(result['diff'])
     module.exit_json(**result)