Skip to content

Commit

Permalink
test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ansibleguy committed Dec 9, 2023
1 parent 59ea841 commit d42b517
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Then - install the collection itself:
ansible-galaxy collection install git+https://github.com/ansibleguy/collection_opnsense.git

# stable/tested version:
ansible-galaxy collection install git+https://github.com/ansibleguy/collection_opnsense.git,1.2.7
## OR
ansible-galaxy collection install ansibleguy.opnsense

# install to specific directory for easier development
Expand Down
5 changes: 4 additions & 1 deletion tests/cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,10 @@
- name: 'test4'
type: 'CNAME'
state: 'absent'
ignore_errors: true # domain does not exist
register: bind_cleanup1
failed_when:
- bind_cleanup1.failed
- "'does not seem to exist' not in bind_cleanup1.msg"

- name: Cleanup BIND Domains
ansibleguy.opnsense.bind_domain:
Expand Down
7 changes: 4 additions & 3 deletions tests/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,13 @@
target: 'cron'

tasks:
- name: Listing (none)
# NOTE: one exists because of IDS
- name: Listing
ansibleguy.opnsense.list:
register: opn7
failed_when: >
'data' not in opn7 or
opn7.data | length != 0
opn7.data | length != 1
- name: Removing - does not exist
ansibleguy.opnsense.cron:
Expand Down Expand Up @@ -123,7 +124,7 @@
register: opn8
failed_when: >
'data' not in opn8 or
opn8.data | length != 2
opn8.data | length != 3
when: not ansible_check_mode

- name: Cleanup
Expand Down

0 comments on commit d42b517

Please sign in to comment.