bind_record - remove bad MX-validation (fix #105)

ansibleguy · Oct 7, 2024 · c569d25 · c569d25
1 parent 3682a87
commit c569d25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/plugins/module_utils/main/bind_record.py b/plugins/module_utils/main/bind_record.py
@@ -62,8 +62,6 @@ def check(self) -> None:
                     self.m.fail_json(f"Value '{self.p['value']}' is not a valid IPv4-address!")
                 elif self.p['type'] == 'AAAA' and not is_ip6(self.p['value']):
                     self.m.fail_json(f"Value '{self.p['value']}' is not a valid IPv6-address!")
-                elif self.p['type'] == 'MX' and not valid_hostname(self.p['value']):
-                    self.m.fail_json(f"Value '{self.p['value']}' is not a valid hostname!")
 
         # custom matching as dns round-robin allows for multiple records to match..
         if self.existing_entries is None:

diff --git a/tests/bind_record.yml b/tests/bind_record.yml
@@ -52,8 +52,6 @@
         - {t: 'A', v: '2001:db8::1'}
         - {t: 'AAAA', v: 'not-an-ip'}
         - {t: 'AAAA', v: '192.168.0.1'}
-        - {t: 'MX', v: 'not-a-hostname'}
-        - {t: 'MX', v: '192.168.0.1'}
 
     - name: Adding 1
       ansibleguy.opnsense.bind_record:
@@ -217,6 +215,18 @@
       failed_when: not opn14.failed
       when: not ansible_check_mode
 
+    - name: Adding 4 (mx)
+      ansibleguy.opnsense.bind_record:
+        domain: 'test4.ansibleguy'
+        name: ''
+        type: 'MX'
+        value: '10 mx.test.ansibleguy.net.'
+      register: opn11
+      failed_when: >
+        opn11.failed or
+        not opn11.changed
+      when: not ansible_check_mode
+
     - name: Cleanup
       ansibleguy.opnsense.bind_record:
         domain: 'test4.ansibleguy'
@@ -226,6 +236,7 @@
       loop:
         - {'n': 'test1'}
         - {'n': 'test2', 't': 'TXT'}
+        - {'n': '', 't': 'MX'}
       when: not ansible_check_mode
 
     - name: Cleanup domain