Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-setup.sh: just ignore the podman-docker shim if it's installed #1312

Closed
wants to merge 2 commits into from
Closed

test-setup.sh: just ignore the podman-docker shim if it's installed #1312

wants to merge 2 commits into from

Conversation

goneri
Copy link
Contributor

@goneri goneri commented May 10, 2024

No description provided.

@goneri goneri requested review from a team as code owners May 10, 2024 19:46
ssbarnea
ssbarnea reviewed May 23, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reasoning for this change? The less verbose behavior may make it harder to debug or prevent regressions.

ssbarnea
ssbarnea requested changes May 23, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work as intended because docker shim also defines DOCKER_HOST variable, so execution will still fail.

@ssbarnea ssbarnea self-assigned this May 23, 2024
@goneri
Copy link
Contributor Author

goneri commented May 23, 2024

This does not work as intended because docker shim also defines DOCKER_HOST variable, so execution will still fail.

Hum. It was working fine on Fedora 40 with this change and docker shim installed.

@goneri goneri closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees

@ssbarnea ssbarnea

Labels
minor
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goneri @ssbarnea