Add file icon #1269
Open
Add file icon #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
approved these changes
May 3, 2024
priyamsahoo
requested changes
May 6, 2024
There was a problem hiding this comment.
@GeorchW, thanks for pointing it out. We already have an SVG located at the images dir. Kindly update the PR to use that SVG rather than adding a new PNG.
Yes, I used that SVG file and adjusted the margins and the color slightly to fit with the other file icons in VS Code. The original icon is bigger and brighter and thus looks out-of-place. I had a look at it in both dark and light mode, and the adjusted color works for both. (I just had a look at the default dark and light themes, I didn't check every theme there is.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt that it's a bit ugly to have no icon for Ansible files.