Skip to content

Fix OpenAPI schema validation message mismatch#16372

Merged
tvo318 merged 1 commit intoansible:develfrom
tvo318:fix-valid-openapi
Mar 25, 2026
Merged

Fix OpenAPI schema validation message mismatch#16372
tvo318 merged 1 commit intoansible:develfrom
tvo318:fix-valid-openapi

Conversation

@tvo318
Copy link
Member

@tvo318 tvo318 commented Mar 25, 2026

Summary

  • Fixed mismatch between validation check message and actual output
  • Workflow now correctly detects when OpenAPI schema validation passes
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

Details

The GitHub Actions workflow at .github/workflows/api_schema_check.yml:66 checks for the message "✓ Schema is valid", but the Makefile was printing "✓ OpenAPI Schema is valid!". This mismatch caused the workflow to always report validation as FAILED even when the schema was actually valid.

Updated Makefile:584 to print the exact message the workflow expects, ensuring proper detection of successful validation.

Test plan

  • Code change reviewed
  • Verify workflow correctly shows validation passing when schema is valid
  • Verify workflow correctly shows validation failing when schema is invalid

🤖 Generated with Claude Code


Note

Low Risk
Low risk: only changes the success print string in the validate-openapi-schema Makefile target to match CI/workflow expectations.

Overview
Updates the Makefile validate-openapi-schema target to print ✓ Schema is valid (instead of ✓ OpenAPI Schema is valid!) so CI checks that grep for this exact success message correctly detect a passing OpenAPI schema validation.

Written by Cursor Bugbot for commit ebf2e26. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated validation success output message.

@tvo318 tvo318 requested a review from Jaapis March 25, 2026 17:14
@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84b05c2c-1380-4c88-93ed-4da067d70e66

📥 Commits

Reviewing files that changed from the base of the PR and between 310dd3e and ebf2e26.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

Updated the success message in the validate-openapi-schema Makefile target from ✓ OpenAPI Schema is valid! to ✓ Schema is valid. No changes to validation logic or behavior.

Changes

Cohort / File(s) Summary
Makefile Output Message
Makefile
Updated the success output string in the validate-openapi-schema target to display a shorter confirmation message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing a mismatch in the OpenAPI schema validation message output in the Makefile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tvo318 tvo318 requested a review from fosterseth March 25, 2026 17:15
@sonarqubecloud
Copy link

@tvo318 tvo318 merged commit cd7f6f6 into ansible:devel Mar 25, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants