Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.16] Fix installing roles containing symlinks (#82911) #83137

Merged
merged 1 commit into from May 9, 2024
Merged

[stable-2.16] Fix installing roles containing symlinks (#82911) #83137

merged 1 commit into from May 9, 2024

Commits on Apr 24, 2024

  1. Fix installing roles containing symlinks (ansible#82911) 

    * Fix installing roles containing symlinks

Fix sanitizing tarfile symlinks relative to the link directory instead of the archive

For example:

role
├── handlers
│   └── utils.yml -> ../tasks/utils/suite.yml

The link ../tasks/utils/suite.yml will resolve to a path outside of the link's directory, but within the role

role/handlers/../tasks/utils/suite.yml

the resolved path relative to the role is tasks/utils/suite.yml, but if the symlink is set to that value, tarfile would extract it from role/handlers/tasks/utils/suite.yml

* Replace overly forgiving test case with tests for a symlink in a subdirectory of the archive and a symlink in the archive dir when these are not equivalent.

* Build test case from role files to make it easier to add test cases

Fixes ansible#82702
Fixes ansible#81965
Fixes ansible#82051

(cherry picked from commit e84240d)
    @s-hertel
    s-hertel committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    aeb31ee View commit details
    Browse the repository at this point in the history