porting guide 2.19 - describe lazy complex var eval impact on builtin filters/tests #2639
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for common Jinja2 filters/tests
oraNod
reviewed
May 18, 2025
oraNod
reviewed
May 28, 2025
felixfontein
added
the
backport-2.19
|
@s-hertel sorry for the delay here - do you agree with the suggested edits or are there still open questions on this PR? |
|
Would be great to get this merged before the ansible-core 2.19.0 release happens. |
|
Sorry for not following up sooner. I wanted to see how ansible/ansible#85201 would play out (whether my advice would help them, and if there were any better workarounds or whether more related changes would trickle in for 2.19). Feel free to merge this, and I'll follow up if I can improve it in the future. |
|
Also feel free to push changes directly to my branch, @oraNod if you want to clarify anything, like your suggested change. This didn't get stuck because of your review, just my uncertainty if it's complete or good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generally covered by https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_12.html#lazy-templating, but t I think it would be helpful to give a couple examples as well.