Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect parts from docs #2388

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Remove incorrect parts from docs #2388

merged 1 commit into from
Feb 4, 2025

Conversation

felixfontein
Copy link
Collaborator

The community.general.jc filter never was a sub-plugin for cli_parse. Having it listed as one is wrong and confuses users. It was originally added there in ansible/ansible#74563 for unknown reasons.

Ref: https://forum.ansible.com/t/39999

@felixfontein felixfontein added backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch labels Feb 4, 2025
oraNod
oraNod approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @felixfontein

@oraNod oraNod merged commit f951472 into ansible:devel Feb 4, 2025
11 checks passed
@patchback Patchback
Copy link

patchback bot commented Feb 4, 2025 •
edited
Loading

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/f9514729a35174c8a51b084991dc025e8166e94d/pr-2388

Backported as #2389

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 4, 2025
@felixfontein @patchback
Remove incorrect parts from docs. (#2388)
330fb98 
(cherry picked from commit f951472)
@patchback Patchback
Copy link

patchback bot commented Feb 4, 2025 •
edited
Loading

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/f9514729a35174c8a51b084991dc025e8166e94d/pr-2388

Backported as #2390

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Feb 4, 2025
Merged
patchback bot pushed a commit that referenced this pull request Feb 4, 2025
@felixfontein @patchback
Remove incorrect parts from docs. (#2388)
cca5b59 
(cherry picked from commit f951472)
@patchback patchback bot mentioned this pull request Feb 4, 2025
Merged
@patchback Patchback
Copy link

patchback bot commented Feb 4, 2025 •
edited
Loading

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/f9514729a35174c8a51b084991dc025e8166e94d/pr-2388

Backported as #2391

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 4, 2025
@felixfontein @patchback
Remove incorrect parts from docs. (#2388)
e096053 
(cherry picked from commit f951472)
@patchback patchback bot mentioned this pull request Feb 4, 2025
Merged
oraNod pushed a commit that referenced this pull request Feb 4, 2025
@patchback @felixfontein
Remove incorrect parts from docs. (#2388) (#2391)
74517be 
(cherry picked from commit f951472)

Co-authored-by: Felix Fontein <[email protected]>
oraNod pushed a commit that referenced this pull request Feb 4, 2025
@patchback @felixfontein
Remove incorrect parts from docs. (#2388) (#2389)
8ab37e9 
(cherry picked from commit f951472)

Co-authored-by: Felix Fontein <[email protected]>
oraNod pushed a commit that referenced this pull request Feb 4, 2025
@patchback @felixfontein
Remove incorrect parts from docs. (#2388) (#2390)
6438880 
(cherry picked from commit f951472)

Co-authored-by: Felix Fontein <[email protected]>
@felixfontein felixfontein deleted the jc branch February 4, 2025 15:04
@felixfontein
Copy link
Collaborator Author

I didn't spot it, I just reacted on a user question :) Thanks for reviewing and merging @oraNod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oraNod oraNod oraNod approved these changes

Assignees
No one assigned
Labels
backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @oraNod