Raise error when invalid requirements are parsed

Fixes: #364 Signed-off-by: Abhijeet Kasurde <[email protected]>
ansible · Jun 6, 2023 · 519ac1e · 519ac1e
1 parent 6fa55e3
commit 519ac1e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/ansible_builder/_target_scripts/introspect.py b/src/ansible_builder/_target_scripts/introspect.py
@@ -345,7 +345,8 @@ def sanitize_requirements(collection_py_reqs):
  consolidated.append(req)
  seen_pkgs.add(req.name)
  except Exception as e:
- logger.warning('Warning: failed to parse requirements from %s, error: %s', collection, e)
+ logger.error('Failed to parse requirements from %s, error: %s', collection, e)
+ sys.exit(1)
 
  # removal of unwanted packages
  sanitized = []

diff --git a/test/unit/test_introspect.py b/test/unit/test_introspect.py
@@ -1,4 +1,5 @@
 import os
+import pytest
 
 from ansible_builder._target_scripts.introspect import process, process_collection, simple_combine, sanitize_requirements
 
@@ -32,3 +33,9 @@ def test_single_collection_metadata(data_dir):
 
  assert py_reqs == ['pyvcloud>=14']
  assert sys_reqs == []
+
+
+def test_corrupt_python_requirements():
+ with pytest.raises(SystemExit) as excinfo:
+ sanitize_requirements({'test.metadata': ['invalid_package=1']})
+ assert excinfo.value.code == 1