-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #239 , use python-style templating instead of Jinja in the plugins login_cmd_template #240
base: main
Are you sure you want to change the base?
Conversation
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
I tested by editing this change into my venv locally and can now log in correctly to ec2 instances by calling |
55ae73e
to
9279b58
Compare
It affects users on all plugins - updated the PR to address each. |
git clean -xdf tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3 rm -rf ../python*-molecule-plugins*23.5.3*.* See ansible-community#155 See ansible-community#237 See ansible-community#240 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Any news on this? |
git clean -xdf tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3 rm -rf ../python*-molecule-plugins*23.5.3*.* See ansible-community#155 See ansible-community#237 See ansible-community#240 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Any news on this PR? This bug breaks some of the plugin functionality quite badly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied these changes locally and can confirm it fixes the issue.
Can also confirm, that this fixes the issue. |
@danielpodwysocki Please add a label to the PR. Would recommend to use 'patch' here. Otherwise following check is failing to success 'ack / ack / ack (pull_request_target) '. |
@ekin-oener-provsn I miss permissions to do that here, I could only create the PR but seems I cannot edit labels. It will need to be someone with enough access to this repo. |
…nja in all drivers login_cmd_template This file assumes Jinja templating for the port parameter and passes a Jinja-style "{{ port }}". https://github.com/ansible/molecule/blob/main/src/molecule/command/login.py#L105 When it reaches molecule, it is subsituted in this file and is done by python calling `.format()` on the string. That causes it to not render correctly and gives users issues running molecule login. ref: ansible-community#239 Fixed all affected plugins.
Confirm. Fixes the same issue for me. |
Fixes the issue on Arch Linux. Seems good to merge. |
Bump... the fix seems good, we just need a maintainer to add the label to the PR as the submitter asserts they lack permission to edit the labels. |
This file assumes Jinja templating for the port parameter and passes a Jinja-style "{{ port }}".
https://github.com/ansible/molecule/blob/main/src/molecule/command/login.py#L105
When it reaches molecule, it is subsituted in this file and is done by python calling
.format()
on the string. That causes it to not render correctly and gives users issues running molecule login.ref: #239