Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change updates the modules to use the new client pyvmomi/rest classes that were created with the last release. By using these client classes, a lot of code that was in the original module base classes can be removed.
The code that is in the client classes is shared by plugins and modules. Theres still a lot of methods that are used by modules only and include module specific logic. Those methods are staying in the module base classes
I also added some unit tests to cover the basic. I think ill open another PR to add tests to cover most/all methods in these classes.
ISSUE TYPE
COMPONENT NAME
pvmomi module base class - _vmware.py
rest module base class - _vmware_rest.py