Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/content library #109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Migrates the community vmware_content_library_manager functionality here.
I decided to split this module into two, one for local libraries and one for subscribed libraries. The module was getting too complex trying to fit them both in one.
I also added functionality for authentication and publishing local libraries which was not included in the original.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

local_content_library
subscribed_content_library

ADDITIONAL INFORMATION

The subscribed library module can only be tested if theres a library to subscribe to, so i combined their integration tests into one. I figured that was OK since both are still being tested thoroughly

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 28.43602% with 151 lines in your changes missing coverage. Please review.

Project coverage is 27.66%. Comparing base (5d1f0b9) to head (792beda).

Files with missing lines Patch % Lines
plugins/modules/local_content_library.py 26.95% 84 Missing ⚠️
plugins/modules/subscribed_content_library.py 30.20% 67 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   27.60%   27.66%   +0.05%     
==========================================
  Files          35       37       +2     
  Lines        2840     3051     +211     
  Branches      534      576      +42     
==========================================
+ Hits          784      844      +60     
- Misses       2056     2207     +151     
Flag Coverage Δ
sanity 27.66% <28.43%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant