-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmware_vm_inventory - fixed hostgroups being created automatically when the with_path option is enabled #2248
base: main
Are you sure you want to change the base?
Conversation
Removed the piece that automatically created the host groups from the VM path.
Build failed. ❌ ansible-tox-linters FAILURE in 4m 31s |
Removed unnecessary ansible.module_utils.six module.
Build failed. ✔️ ansible-tox-linters SUCCESS in 5m 08s |
It makes sense to look for rooted 'path' value in variable instead of group_names
Updated Inventory with rooted 'with_path' option test.
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 28s |
@mariolenz please take a look when you have a chance. Minimal changes, shouldn't interfere with anything. |
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 53s |
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 32s |
recheck |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 21s |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 5m 40s |
SUMMARY
Fixes #1688
Plugin should not create hostgroups automatically when
with_path
is true. There iskeyed_groups
parameter for that.ISSUE TYPE
COMPONENT NAME
community.vmware.vmware_vm_inventory
ADDITIONAL INFORMATION