New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Simplified guest module #2052

Open

mariolenz wants to merge 11 commits into ansible-collections:main from mariolenz:simplified_guest_module

Collaborator

mariolenz commented Apr 21, 2024

SUMMARY

I think the vmware_guest module tries to do too many things at once and, in consequence, is far to complex and pretty much unmaintainable. Maybe we should try and create a simpler module that's easier to maintain and move some functionality to other (possibly new) modules.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

guest
vmware_guest

ADDITIONAL INFORMATION

ansible-collections/vmware.vmware#4 (comment)

mariolenz mentioned this pull request

Promote vmware guest ansible-collections/vmware.vmware#4

Closed

mariolenz force-pushed the simplified_guest_module branch from d825455 to d1f230f Compare

April 21, 2024 13:52


          Simplified guest module

9d48694

mariolenz force-pushed the simplified_guest_module branch from d1f230f to 9d48694 Compare

April 21, 2024 14:00

softwarefactory-project-zuul bot commented Apr 21, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1fc37356def749b692f51e562da7b592

✔️ ansible-tox-linters SUCCESS in 10m 53s
✔️ build-ansible-collection SUCCESS in 11m 32s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 23m 34s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 22m 35s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 54m 44s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 00m 10s
✔️ ansible-galaxy-importer SUCCESS in 5m 14s

softwarefactory-project-zuul bot commented Apr 21, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/51f6758c8c5a44beb022eaaf30e6c7ea

✔️ ansible-tox-linters SUCCESS in 11m 45s
✔️ build-ansible-collection SUCCESS in 11m 31s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 15m 28s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 56s


          Add first integration tests

ec85f8c

mariolenz force-pushed the simplified_guest_module branch from 03fda7c to ec85f8c Compare

April 21, 2024 16:31

softwarefactory-project-zuul bot commented Apr 21, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b3cec9b28c304951a48fa97210b254e8

✔️ ansible-tox-linters SUCCESS in 10m 10s
✔️ build-ansible-collection SUCCESS in 11m 33s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 14m 54s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 20s

mariolenz added 2 commits

April 22, 2024 18:27


          Drop self.params['template'] from deploy_vm()

7209d9b


          Drop customize_exist_vm()

10d161f

softwarefactory-project-zuul bot commented Apr 22, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/03f959d5673d45cf8cca287defc10979

✔️ ansible-tox-linters SUCCESS in 12m 17s
✔️ build-ansible-collection SUCCESS in 11m 57s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 15m 38s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 05s

mariolenz added 3 commits

May 5, 2024 14:37


          Drop autoselect_datastore()

6dbf05f


          Drop self.params['disk']

1fbb6bc


          Drop self.params['template']

5f318f8

softwarefactory-project-zuul bot commented May 5, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5a6f81ea790d4bf0bd0d6c5fc4f2154c

✔️ ansible-tox-linters SUCCESS in 10m 35s
✔️ build-ansible-collection SUCCESS in 11m 10s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 12m 57s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 16s


          Drop self.params['networks'] + self.params['customization']

54c346a

softwarefactory-project-zuul bot commented May 5, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/deacfa8807a8481d8a15f0736db42308

✔️ ansible-tox-linters SUCCESS in 11m 52s
✔️ build-ansible-collection SUCCESS in 11m 44s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 16m 00s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 19s


          Fix first integration tests

58ed77b

softwarefactory-project-zuul bot commented May 6, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a912fa8ac87f40c8a69570bfc776ffb8

✔️ ansible-tox-linters SUCCESS in 11m 06s
✔️ build-ansible-collection SUCCESS in 11m 01s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 17m 05s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 26s


          Drop self.params['annotation']

62dbb00

mariolenz force-pushed the simplified_guest_module branch from 37e934e to 62dbb00 Compare

May 6, 2024 17:37

softwarefactory-project-zuul bot commented May 6, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7dddcc7d427042b8933b2f3b52f58549

✔️ ansible-tox-linters SUCCESS in 11m 40s
✔️ build-ansible-collection SUCCESS in 10m 59s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 18m 55s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 32s

mariolenz closed this

mariolenz reopened this


          Drop version_added

4447d76

softwarefactory-project-zuul bot commented May 6, 2024

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/69d753802440457395012310976a2479

✔️ ansible-tox-linters SUCCESS in 10m 59s
✔️ build-ansible-collection SUCCESS in 11m 14s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 16m 14s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 18s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet