vmware_guest_snapshot - remove datacenter and folder parameter

[Nina2244]

SUMMARY

Remove datacenter and folder parameter because its not used anywhere in the code.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_guest_snapshot.py

ADDITIONAL INFORMATION

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1cbd22abd6124d909f9c9fc9c11d903a

✔️ ansible-tox-linters SUCCESS in 9m 39s
✔️ build-ansible-collection SUCCESS in 10m 03s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 22m 03s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 17m 48s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 FAILURE in 28m 30s
✔️ ansible-galaxy-importer SUCCESS in 4m 21s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/da0733dea54d4bf3963f6e4dd430564f

✔️ ansible-tox-linters SUCCESS in 9m 51s
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 55s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 20s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 FAILURE in 31m 00s
✔️ ansible-galaxy-importer SUCCESS in 3m 22s

[sky-joker]

The datacenter and folder parameters are referred to by the get_vm method in the PyVmomi class, so please do not remove them.
https://github.com/ansible-collections/community.vmware/blob/main/plugins/modules/vmware_guest_snapshot.py#L477
https://github.com/ansible-collections/community.vmware/blob/main/plugins/module_utils/vmware.py#L1291-L1293

[mariolenz]

@sky-joker @Nina2244 I though you've left this collection. Great to see you again!

I didn't find the time yet to have a closer look at this PR, but FYI I'm preparing a new major release so we can do some breaking changes if you think they're needed or make the collection more healthy.

edit:

Last day to release a new major version and get it into the Ansible Community Package 11 would be 2024-11-04, but I would like to do the next major release sooner. But we do have the opportunity to implement breaking changes if we think they make sense ATM 😉