vmware_local_user_manager - shell access

[cbreuil-orange]

SUMMARY

vmware_local_user_manager

Add the possibility to grants or not the "shell access" for user creation or update

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_local_user_manager

ADDITIONAL INFORMATION

https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/vim.host.LocalAccountManager.PosixAccountSpecification.html

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/28df9c727bf54679a45ad5888cede633

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection RETRY_LIMIT in 11m 10s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

[mnaser]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e8aac8fa0f024d5aa6db657ea71cc7c4

❌ ansible-tox-linters FAILURE in 8m 40s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2843b36651d34b41a4079e1a4f26744d

✔️ ansible-tox-linters SUCCESS in 8m 44s
✔️ build-ansible-collection SUCCESS in 9m 35s
❌ ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006196234 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006196235 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006196236 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006196237 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

[cbreuil-orange]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e01f0d29720c46cf940db5968c8050f8

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 19s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 07s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 42m 21s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006344060 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 5m 07s

[ihumster]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7a027bc472ff4a84a2027134c6358573

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 29s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 18m 56s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 39s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 54m 58s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 41m 03s
✔️ ansible-galaxy-importer SUCCESS in 5m 03s

[cbreuil-orange]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/57cf5e9b89934662a6a6855c03192059

✔️ ansible-tox-linters SUCCESS in 9m 44s
✔️ build-ansible-collection SUCCESS in 10m 45s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 13m 57s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 44s

[ihumster]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/842630dbf6be40daba747f251a81c628

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 55s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 23m 31s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 48m 21s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006346731 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 5m 08s

[mariolenz]

If I understand the documentation correctly, I don't see how this can be implemented in a way that won't possibly break existing playbooks- at least not as long as there's a default for this parameter. I think it would be better to remove the defaul and ignore the parameter if it isn't set.

We could add a default in the next major release (4.0.0), but would prefer it to be false because it would be more secure by design. Giving accounts shell access (or any other privileges) should always be done explicitly imho ;-)

Additionally, please add a changelog fragment similar to this one.