Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests to GH Actions #1747

Merged
merged 1 commit into from
May 24, 2023

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Move some tests to GH Actions.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

#1746

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6bf428ffe3724d8a9bc1f9802fd13cc2

✔️ ansible-tox-linters SUCCESS in 8m 53s
✔️ build-ansible-collection SUCCESS in 9m 14s
ansible-test-sanity-docker-devel FAILURE in 11m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 09s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 32s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 7m 11s
✔️ ansible-galaxy-importer SUCCESS in 4m 13s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3feb1514050f4b3787da9644291f79eb

✔️ ansible-tox-linters SUCCESS in 8m 24s
✔️ build-ansible-collection SUCCESS in 9m 11s
ansible-test-sanity-docker-devel FAILURE in 10m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 20s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 48s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 14s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 57s
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@mariolenz mariolenz changed the title [WIP] Move some tests to GH Actions Move some tests to GH Actions May 24, 2023
@mariolenz
Copy link
Collaborator Author

@jillr Could you please review this PR? Ideally in combination with ansible/ansible-zuul-jobs#1803

@mariolenz mariolenz requested a review from jillr May 24, 2023 17:01
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariolenz Do you want me to update the branch protections after this merges for the new checks? (IMO you should have access to do this yourself for this repo. I'm happy to give you maintainer permissions on the repo but you need admin for branch protections, I'd like to double check with the community team before changing admin rights on a collection just to be in communication with them about it. What do you think?)

@mariolenz
Copy link
Collaborator Author

Do you want me to update the branch protections after this merges for the new checks? (IMO you should have access to do this yourself for this repo. I'm happy to give you maintainer permissions on the repo but you need admin for branch protections, I'd like to double check with the community team before changing admin rights on a collection just to be in communication with them about it. What do you think?)

This looks like another discussion to to me... maybe even two discussions. But there are so many other things to do at the moment that I suggest to move it / them to the future. I don't want to loose track, you know? There are several PRs and issues I have to work on, then there is the question about the future of the CI... oh, and I have a main job, also ;-)

I'll merge this PR and will backport it to the stable-2.x branch (stable-1.x is EOL so we can ignore it). Let's discuss branch protection and maintainer / admin permissions at another time.

@mariolenz mariolenz added CI CI related issues mergeit labels May 24, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/eef6787c29724bb78c0450715c1ed6a9

✔️ ansible-tox-linters SUCCESS in 8m 26s
✔️ build-ansible-collection SUCCESS in 7m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 40s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 44s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 8m 24s
✔️ ansible-galaxy-importer SUCCESS in 6m 04s

@softwarefactory-project-zuul
Copy link

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz mariolenz merged commit 931ab0b into ansible-collections:main May 24, 2023
@mariolenz mariolenz deleted the 20230524_ci branch May 24, 2023 18:54
softwarefactory-project-zuul bot pushed a commit to ansible/ansible-zuul-jobs that referenced this pull request May 24, 2023
community.vmware: Remove sanity and unity tests

Depends-On: ansible-collections/community.vmware#1747
Remove sanity and unity tests from community.vmware.
ansible-collections/community.vmware#1746

Reviewed-by: Jill R
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 24, 2023
stable-2.x: Backport move some tests to GH Actions

SUMMARY
Backport #1747: Move some tests to GH Actions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ADDITIONAL INFORMATION
#1746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related issues mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants