Add example using four networks to map

[Tronde]

SUMMARY

Added an example that shows how networks mapping is done with an OVA template that contains four source networks.

ISSUE TYPE

• Docs Pull Request

COMPONENT NAME

• vmware_deploy_ovf

ADDITIONAL INFORMATION

Lines added:

    # Deploy an OVA template, with network mapping of four source networks (Internal, External, Management, and HA) to target networks (VM_NET_1, VM_NET_2, VM_NET_3, and VM_NET_4)
    - community.vmware.vmware_deploy_ovf:
        hostname: '{{ vcenter_hostname }}'
        username: '{{ vcenter_username }}'
        password: '{{ vcenter_password }}'
        datacenter: Datacenter1
        cluster: Cluster1
        datastore: vsandatastore
        name: NewVM
        networks:
          Internal: 'VM_NET_1'
          External: 'VM_NET_2'
          Management: 'VM_NET_3'
          HA: 'VM_NET_4'
        power_on: false
        ovf: files/mytemplate.ova
      delegate_to: localhost

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5c72b1ef57904c639cba5fcf303da6c1

✔️ ansible-tox-linters SUCCESS in 8m 25s
✔️ build-ansible-collection SUCCESS in 9m 12s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 35s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 59s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 35s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 09s
✔️ ansible-galaxy-importer SUCCESS in 4m 02s

[mariolenz]

@Tronde I'm afraid this won't do. You see, the documentation is generated from the module code. So your changes will probably be undone when we release a another version (which includes re-generating the documentation). You should add this to the EXAMPLES in the module to be on the safe side, that is here:

community.vmware/plugins/modules/vmware_deploy_ovf.py

Lines 141 to 173 in f50a717

	EXAMPLES = r'''
	- community.vmware.vmware_deploy_ovf:
	hostname: '{{ vcenter_hostname }}'
	username: '{{ vcenter_username }}'
	password: '{{ vcenter_password }}'
	ovf: /path/to/ubuntu-16.04-amd64.ovf
	wait_for_ip_address: true
	delegate_to: localhost
	# Deploys a new VM named 'NewVM' in specific datacenter/cluster, with network mapping taken from variable and using ova template from an absolute path
	- community.vmware.vmware_deploy_ovf:
	hostname: '{{ vcenter_hostname }}'
	username: '{{ vcenter_username }}'
	password: '{{ vcenter_password }}'
	datacenter: Datacenter1
	cluster: Cluster1
	datastore: vsandatastore
	name: NewVM
	networks: "{u'VM Network':u'{{ ProvisioningNetworkLabel }}'}"
	power_on: false
	ovf: /absolute/path/to/template/mytemplate.ova
	delegate_to: localhost
	- community.vmware.vmware_deploy_ovf:
	hostname: '{{ vcenter_hostname }}'
	username: '{{ vcenter_username }}'
	password: '{{ vcenter_password }}'
	datacenter: Datacenter1
	esxi_hostname: test-server
	datastore: test-datastore
	ovf: /path/to/ubuntu-16.04-amd64.ovf
	delegate_to: localhost
	'''

[Tronde]

OK, then let me edit the PR to put the example in the code of the module. -- E-Mail: ***@***.*** Twitter: https://twitter.com/JoergKastning Internet: https://www.my-it-brain.de Threema-ID: K2Y6W49N OpenPGP-ID: 7A302E30 OpenPGP-Fingerabdruck: 2026 DF56 89B6 F79A E776 B15B 55E2 83FB 7A30 2E30

[Tronde]

Hi @mariolenz ,
I moved the example from the .rst file to the module code. Could you please check if it's OK now?

Cheers,
Tronde

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/16e43e9af8b94e969be1b857f15ff76a

❌ ansible-tox-linters FAILURE in 8m 31s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[Tronde]

Sorry, I may need some help here as I cannot figure out what I did wrong causing the ansible/check to fail.

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b545f6b104d34103ba72fff794098258

❌ ansible-tox-linters FAILURE in 8m 23s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[mariolenz]

Sorry, I may need some help here as I cannot figure out what I did wrong causing the ansible/check to fail.

I don't understand why this fails, either :-/

BTW: You've committed your changes to the main branch of your fork. That might be problematic. Not for us, but for you. You should have created a so-called feature branch.

You see, merging the PR creates a new commit in this repo which will be different from the one in your fork. This will probably lead to a merge conflict. If you create a feature branch for a PR, you can simply delete it once the PR is merged and sync your main branch with ours. That's usually a lot easier.

[Tronde]

Sorry, I may need some help here as I cannot figure out what I did wrong causing the ansible/check to fail.

I don't understand why this fails, either :-/

Well, at least that makes two of us. ;-)

BTW: You've committed your changes to the main branch of your fork. That might be problematic. Not for us, but for you. You should have created a so-called feature branch.

You see, merging the PR creates a new commit in this repo which will be different from the one in your fork. This will probably lead to a merge conflict. If you create a feature branch for a PR, you can simply delete it once the PR is merged and sync your main branch with ours. That's usually a lot easier.

Yeah, I know. I thought this would be an easy and quick one so I didn't bother creating a feature branch first. Who could have guessed that there would be an issue with just adding a comment. ;-)