Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a try except of ManagedObjectNotFound for Vms #1512

Closed
wants to merge 3 commits into from

Conversation

Nina2244
Copy link
Contributor

SUMMARY

Try to fix the Problem that sometimes the vms renamed and removed between the finding and the use of it. (vCLS Vms)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • vmware_vm_info.py
  • vmware_vm_vss_dvs_migrate.py
ADDITIONAL INFORMATION

…ware

In the find_vm_by_name form module_utils.vmware the try expect is used
This is because vms sometimes renamed or removed between the finding and the use of the object
@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 4m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 35s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 52s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 11s (non-voting)
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 00s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 23s
ansible-test-cloud-integration-vcenter7_2esxi-stable212 FAILURE in 16m 45s
ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 10m 50s
ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 13m 05s
✔️ ansible-galaxy-importer SUCCESS in 4m 10s

@Nina2244
Copy link
Contributor Author

Nina2244 commented May 2, 2023

@mariolenz can you please trigger a recheck? So I can try to fix it. Because there the current check isn't possible to read anymore.

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.vmware for 1512,ebead1b9564966913051399fcec938d6a27abcbc

@mariolenz
Copy link
Collaborator

@Nina2244 Looks like you have to rebase. Sorry :-(

@Nina2244
Copy link
Contributor Author

New Pull Request after Rebase #1733

@Nina2244 Nina2244 closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants