-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve efficiency of Natural <-> ByteString
#3386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56341c5
to
520d70a
Compare
Natural -> ByteString
Natural <-> ByteString
12d0d9c
to
9a6c70b
Compare
6eb11b7
to
98d71a7
Compare
Me neither. But after precomputing the hashes, the time difference with compilation to
Modular compilation slows things down, because we don't filter out unused definitions early in Core anymore. But not so much (and we can't do much about that):
|
lukaszcz
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've improved efficiency of encoding/decoding Natural to Bytestring.
With very big numbers, the gains are dramatic. With smaller numbers, the gains are more modest but still relevant.
Benchmarks
1,000,000 digits
Natural -> ByteString
ByteString -> Natural
500 digits
Natural -> ByteString
ByteString -> Natural
Unfortunately, I haven't measured any gains by measuring the execution time of the nock pipeline.