Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Review #1

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Initial Review #1

wants to merge 6 commits into from

Conversation

snipebin
Copy link
Contributor

@snipebin snipebin commented Apr 3, 2018 •
edited
Loading

@LeeSaferite Please read through the README and do an initial code review and try to run the tests. This is still WIP but may be to do an initial release. Some things that still need to be done:

  • Update dependencies to latest versions
  • Finish test coverage with unit & e2e tests
  • Make sure all original files from autotrack which contain apache license in the header and were modified include also a modification notice in the header.
  • Add thanks to autotrack authors.
  • Finish documenting plugins (only one documented so far)

@snipebin snipebin requested a review from LeeSaferite April 3, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSaferite LeeSaferite LeeSaferite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snipebin @LeeSaferite