Skip to content

Commit

Permalink
WEB-1471:FIX: lowerCamelcase for gaTaskManager dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
snipebin committed Apr 4, 2018
1 parent 21ee0cd commit c98b83e
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions ga-autotrack-ids.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ga-autotrack-ids.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/plugins/hit-id-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class HitIdTracker {
* @param {?HitIdTrackerOpts} opts Passed by the require command.
*/
constructor(tracker, opts) {
if (!tracker.plugins_ || tracker.plugins_.keys.indexOf('GaTaskManager') === -1) {
if (!tracker.plugins_ || tracker.plugins_.keys.indexOf('gaTaskManager') === -1) {
throw new Error(`The HitIdTracker plugin requires the GaTaskManager
plugin to work. Please load and require the GaTaskManager for this
tracker before requiring the HitIdTracker plugin.`);
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/hit-timestamp-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class HitTimestampTracker {
* @param {?HitTimestampTrackerOpts} opts Passed by the require command.
*/
constructor(tracker, opts) {
if (tracker.plugins_.keys.indexOf('GaTaskManager') === -1) {
if (tracker.plugins_.keys.indexOf('gaTaskManager') === -1) {
throw new Error(`The HitTimestampTracker plugin requires the GaTaskManager
plugin to work. Please load and require the GaTaskManager for this
tracker before requiring the HitTimestampTracker plugin.`);
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/fixtures/ga-autotrack-ids-rename.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
_ga('require', 'GaTaskManager');
</script>
<script async src="/test/analytics.js"></script>
<script src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.7.0/ga-task-manager.js" async></script>
<script src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.8.1/ga-task-manager.js" async></script>
<script async src="/ga-autotrack-ids.js"></script>
</head>
<body>
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/fixtures/ga-autotrack-ids-reorder.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!doctype html>
<html>
<head>
<script src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.7.0/ga-task-manager.js" async></script>
<script src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.8.1/ga-task-manager.js" async></script>
<script src="/ga-autotrack-ids.js"></script>
<script>
window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date;
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/fixtures/ga-autotrack-ids-sandbox.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
ga('create', 'UA-40941061-3', 'auto');

// Require the plugin
ga('require', 'GaTaskManager');
ga('require', 'gaTaskManager');

// Add a function to customTask
ga('GaTaskManager:addFunctionToTask', 'customTask', 'logShinyString', function(model){
Expand Down Expand Up @@ -44,7 +44,7 @@
ga('send', 'pageview');
}, 5000);
</script>
<script async src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.7.0/ga-task-manager.js"></script>
<script async src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.8.1/ga-task-manager.js"></script>
<script async src="/ga-autotrack-ids.js"></script>
</head>
<body>
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/fixtures/ga-autotrack-ids.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
<head>
<script>
window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date;
ga('require', 'GaTaskManager');
ga('require', 'gaTaskManager');
</script>
<script async src="/test/analytics.js"></script>
<script src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.7.0/ga-task-manager.js" async></script>
<script src="https://cdn.jsdelivr.net/gh/anki/ga-task-manager@v0.8.1/ga-task-manager.js" async></script>
<script async src="/ga-autotrack-ids.js"></script>
</head>
<body>
Expand Down

0 comments on commit c98b83e

Please sign in to comment.