Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: scrollThreshold is not properly applied in inverse mode #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oscar60310
Copy link

What's happened

In inverse mode, scrollThreshold was not properly applied, so we needed to scroll to the end to trigger next function calls.

before.mp4

Solution

We should multiply it with scrollHeight as we did in normal mode.

after.mp4

@BaDo2001
Copy link

@oscar60310 Any update on this?

@oscar60310
Copy link
Author

Hi, the fix should work, but the project seems to be inactive. Therefore, I have duplicated the code into our project instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants