Merge branch 'kurtmckee/fix-patch-stop-order-i...'

anishathalye · Dec 19, 2024 · 82834e6 · 82834e6
2 parents e02111e + 33f5390
commit 82834e6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -217,7 +217,9 @@ def wrap_mkstemp_inner(*args, **kwargs):
     try:
         yield current_root
     finally:
-        [patch.stop() for patch in patches]
+        # Patches must be stopped in reverse order because some patches are nested.
+        # Stopping in the reverse order restores the original function.
+        [patch.stop() for patch in reversed(patches)]
         os.chdir(current_working_directory)
         if sys.version_info >= (3, 12):
             rmtree(current_root, onexc=rmtree_error_handler)