nat46-netdev: Calling risky function (DC.CUSTOM_STRCPY) by Coverity

angus19 · web-flow · commit 17eca626b746 · 2025-05-09T15:43:36.000+08:00
A false positive and we just ignore it.
diff --git a/nat46/modules/nat46-netdev.c b/nat46/modules/nat46-netdev.c
@@ -149,7 +149,8 @@ static int nat46_netdev_create(struct net *net, char *basename, struct net_devic
 		snprintf(devname, strlen(NETDEV_DEFAULT_NAME)+3, "%s%d", NETDEV_DEFAULT_NAME, netdev_count);
 		netdev_count++;
 	} else {
-		snprintf(devname, strlen(basename)+1, "%s", basename);
+		/* coverity[dont_call] false positive + ignore */
+		strcpy(devname, basename); /* In this particular case, we allocate the destination based on the source length, so the strcpy will be safe by construction - destination always has enough size to take the source in */
 	}
 
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(3,17,0)

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,8 @@ static int nat46_netdev_create(struct net net, char basename, struct net_devic`
`149`	`149`	`snprintf(devname, strlen(NETDEV_DEFAULT_NAME)+3, "%s%d", NETDEV_DEFAULT_NAME, netdev_count);`
`150`	`150`	`netdev_count++;`
`151`	`151`	`} else {`
`152`		`- snprintf(devname, strlen(basename)+1, "%s", basename);`
	`152`	`+ /* coverity[dont_call] false positive + ignore */`
	`153`	`+ strcpy(devname, basename); /* In this particular case, we allocate the destination based on the source length, so the strcpy will be safe by construction - destination always has enough size to take the source in */`
`153`	`154`	`}`
`154`	`155`
`155`	`156`	`#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,17,0)`