nat46-netdev: Do not use strcpy

angus19 · angus19 · commit 17e71686379e · 2025-05-09T14:01:30.000+08:00
[Coverity] Calling risky function (DC.CUSTOM_STRCPY)
diff --git a/nat46/modules/nat46-netdev.c b/nat46/modules/nat46-netdev.c
@@ -149,7 +149,7 @@ static int nat46_netdev_create(struct net *net, char *basename, struct net_devic
 		snprintf(devname, strlen(NETDEV_DEFAULT_NAME)+3, "%s%d", NETDEV_DEFAULT_NAME, netdev_count);
 		netdev_count++;
 	} else {
-		strcpy(devname, basename);
+		snprintf(devname, strlen(basename)+1, "%s", basename);
 	}
 
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(3,17,0)

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ static int nat46_netdev_create(struct net net, char basename, struct net_devic`
`149`	`149`	`snprintf(devname, strlen(NETDEV_DEFAULT_NAME)+3, "%s%d", NETDEV_DEFAULT_NAME, netdev_count);`
`150`	`150`	`netdev_count++;`
`151`	`151`	`} else {`
`152`		`- strcpy(devname, basename);`
	`152`	`+ snprintf(devname, strlen(basename)+1, "%s", basename);`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,17,0)`