Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api-gen): add support for function overloads #2020

Closed
wants to merge 1 commit into from
Closed

refactor(api-gen): add support for function overloads #2020

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 27, 2024 •
edited

@JeanMeche JeanMeche mentioned this pull request Apr 27, 2024
Open
josephperrott
josephperrott approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bazel/api-gen/rendering/templates/deprecated-label.tsx Show resolved Hide resolved
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Apr 29, 2024
@josephperrott
Copy link
Member

This PR was merged into the repository by commit a9d6b07.

@JeanMeche JeanMeche deleted the docs/function-overloads branch April 29, 2024 14:55
@bencodezen bencodezen mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: inject() is missing all overloads
2 participants
@JeanMeche @josephperrott