Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/button): combine MatButton and MatAnchor #30492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/button): combine MatButton and MatAnchor #30492

wants to merge 1 commit into from
+100 −207

Conversation

crisbeto
Copy link
Member

Currently we have two directives for each button variant: MatButton which applies to button elements and MatButtonAnchor which applies to anchors.

This is problematic in a couple of ways:

  1. The styles, which can be non-trivial, are duplicated if both classes are used.
  2. Users have to think about which class they're importing.

These changes combine the two classes to resolve the issues and simplify our setup.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Feb 14, 2025
@crisbeto crisbeto requested a review from a team as a code owner February 14, 2025 08:47
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team February 14, 2025 08:47
@crisbeto crisbeto force-pushed the combined-buttons branch 2 times, most recently from 8364588 to 6befd5f Compare February 14, 2025 09:18
@crisbeto
fix(material/button): combine MatButton and MatAnchor
4b47167 
Currently we have two directives for each button variant: `MatButton` which applies to `button` elements and `MatButtonAnchor` which applies to anchors.

This is problematic in a couple of ways:
1. The styles, which can be non-trivial, are duplicated if both classes are used.
2. Users have to think about which class they're importing.

These changes combine the two classes to resolve the issues and simplify our setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner automatically assigned from angular/components-googlers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner automatically assigned from angular/components-googlers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: material/button target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crisbeto