Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/tree): retainining previous objects #30431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Feb 1, 2025

fixes component retaining old data in memory even when its not used causing memory usage to increase

fixes #30322

fixes component retaining old data in memory even when its not used causing memory usage to increase

fixes angular#30322
@naaajii naaajii requested a review from a team as a code owner February 1, 2025 18:55
@naaajii naaajii requested review from mmalerba and wagnermaciel and removed request for a team February 1, 2025 18:55
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 3, 2025
@andrewseguin andrewseguin self-assigned this Feb 3, 2025
@mmalerba
Copy link
Contributor

It looks like there might be a bug with this. There's an internal test failing because some nested child nodes have the same aria-level as their parent while the parent is collapsed. They're display: none while collapsed, so its probably not an issue from an accessibility perspective, but it causes treeHarness.getNodes({level: parentLevel}) to also pick up the hidden children

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/tree target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Tree): Memory leak when changing data source
3 participants