fix(material/form-field): trigger CD when form gets reassigned #30395
Conversation
naaajii
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
| @@ -378,6 +378,8 @@ export class MatFormField | |||
| this._initializeControl(this._previousControl); | |||
| this._previousControl = this._control; | |||
| } | |||
|
|
|||
| this._changeDetectorRef.markForCheck(); | |||
There was a problem hiding this comment.
can we move this inside the above if block? we should only need to do it if the control actually changed
There was a problem hiding this comment.
I guess this broke something and I can't debug this right now cause running input tests makes this laptop go brrrr. I will get back to this later. I'm sorry for delay!
although it shouldn't have broke anything.
I think it never goes into the if statement above when form is getting reassigned.
There was a problem hiding this comment.
Ok, I guess the above if-block was unrelated then, but this still feels like its marking for check far too often. I'm a little bit worried that this could have negative performance implications.
There was a problem hiding this comment.
I have switched the login to check if the validator on the control has changed or not. I couldn't get my head around this any other way as NgOnChange didn't include formControl and equal checks on control doesn't return true either. I'm open to suggestions for improvements.
|
no more working |
gets reassigned fixes the issue we were not marking component for changes when form is reassigned making it not update UI for required asterisk fixes angular#29066
fixes the issue we were not marking component for changes when form is reassigned making it not update UI for required asterisk
fixes #29066