fix(core): handle elements with local refs in event replay serialization logic #56076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion logic Previously, the event replay serialization logic was located before we verify that a `TNode` exists. `TNode`s may not exist in `tView.data` array in several cases, including cases when there is a local ref used on an element: in this case an extra slot in `LView` contains a reference to the same element and `TNode` is not needed. This commit moves the event replay serialization logic a bit lower, after we check for TNode presence. Resolves angular#56073.
AndrewKushnir
added
action: review
iteriani
approved these changes
May 25, 2024
AndrewKushnir
added
action: presubmit
AndrewKushnir
added
action: merge
|
Caretaker note: an existing approval should be sufficient, this PR is ready for merge. |
pkozlowski-opensource
approved these changes
May 27, 2024
|
This PR was merged into the repository by commit ae83646. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
May 27, 2024
…ion logic (#56076) Previously, the event replay serialization logic was located before we verify that a `TNode` exists. `TNode`s may not exist in `tView.data` array in several cases, including cases when there is a local ref used on an element: in this case an extra slot in `LView` contains a reference to the same element and `TNode` is not needed. This commit moves the event replay serialization logic a bit lower, after we check for TNode presence. Resolves #56073. PR Close #56076
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the event replay serialization logic was located before we verify that a
TNodeexists.TNodes may not exist intView.dataarray in several cases, including cases when there is a local ref used on an element: in this case an extra slot inLViewcontains a reference to the same element andTNodeis not needed. This commit moves the event replay serialization logic a bit lower, after we check forTNodepresence.Resolves #56073.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?