Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (*): Add i18n support #2534

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

stherrienaspnet
Copy link
Collaborator

@stherrienaspnet stherrienaspnet commented Apr 5, 2017

Add i18n support (multi-language) using angular-translate.

@benmarten
Copy link
Contributor

Not sure how we merge in this project, but looks to me your commits don't follow the convention:
-AngularJS commit message guidelines

@stherrienaspnet
Copy link
Collaborator Author

Can i change the PR text without cancelling it?

@stherrienaspnet
Copy link
Collaborator Author

I really your PR about warnings 😊

@benmarten
Copy link
Contributor

If you mean how to rename your commits, look into 'git rebase -i HEAD~1'. the force pushing your local branch to remote, i guess ;)
Renaming the PR itself should be possible here on GitHub itself...

@stherrienaspnet
Copy link
Collaborator Author

I forgot a word in my last posy , i mean I really your PR who fix warning message :)

@stherrienaspnet
Copy link
Collaborator Author

The missing word is like

@benmarten
Copy link
Contributor

Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli

@stherrienaspnet
Copy link
Collaborator Author

stherrienaspnet commented Apr 9, 2017 via email

@Awk34 Awk34 self-requested a review April 10, 2017 04:16
@@ -189,6 +189,11 @@ export class Generator extends Base {
filter: val => val.toLowerCase()
}, {
type: 'confirm',
name: 'i18nSupport',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be simpler to just call it i18n

@Ghalleb
Copy link

Ghalleb commented Jun 23, 2017

I would really appreciate to have i8n support...

@saherrera
Copy link

is this working in the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants