-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (*): Add i18n support #2534
base: master
Are you sure you want to change the base?
feat (*): Add i18n support #2534
Conversation
Not sure how we merge in this project, but looks to me your commits don't follow the convention: |
Can i change the PR text without cancelling it? |
I really your PR about warnings 😊 |
If you mean how to rename your commits, look into 'git rebase -i HEAD~1'. the force pushing your local branch to remote, i guess ;) |
I forgot a word in my last posy , i mean I really your PR who fix warning message :) |
The missing word is like |
Check out this cli tool for commit messages: https://github.com/commitizen/cz-cli |
Thanks Ben!
Le 8 avr. 2017 12:41 PM, "Ben Marten" <[email protected]> a écrit :
… Check out this cli tool for commit messages:
https://github.com/commitizen/cz-cli
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2534 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF19cfMUZbnm9u1--Fdqca-HkZoH3aWfks5rt7jMgaJpZM4M0MLN>
.
|
@@ -189,6 +189,11 @@ export class Generator extends Base { | |||
filter: val => val.toLowerCase() | |||
}, { | |||
type: 'confirm', | |||
name: 'i18nSupport', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be simpler to just call it i18n
I would really appreciate to have i8n support... |
is this working in the latest version? |
generator-angular-fullstack$ npm test
)Add i18n support (multi-language) using angular-translate.