Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): [label-has-associated-control] check id's in the for attribute of a label for existence #1761

Merged
merged 6 commits into from
May 21, 2024

Conversation

air2
Copy link
Contributor

@air2 air2 commented Apr 12, 2024

This should fix issue #1759

Copy link

nx-cloud bot commented May 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cd95e0b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @air2, please run yarn update-rule-docs and commit the result

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.47%. Comparing base (4de165d) to head (cd95e0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1761   +/-   ##
=======================================
  Coverage   90.46%   90.47%           
=======================================
  Files         178      178           
  Lines        3345     3359   +14     
  Branches      536      540    +4     
=======================================
+ Hits         3026     3039   +13     
  Misses        185      185           
- Partials      134      135    +1     
Flag Coverage Δ
unittest 90.47% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../tests/rules/label-has-associated-control/cases.ts 100.00% <ø> (ø)
...template/src/rules/label-has-associated-control.ts 88.37% <94.44%> (+2.16%) ⬆️

@JamesHenry JamesHenry merged commit 918cc50 into angular-eslint:main May 21, 2024
7 checks passed
@air2
Copy link
Contributor Author

air2 commented May 28, 2024

@JamesHenry Sorry I had some other projects lately, so I had not time to get back at this, before now, I see it is already, merged, thank you! And sorry for my late reply and not picking your request up sooner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants