SIANXSVC-1193: dotnet-e5e does not handle binary requests as expected #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1193-dotnet-e5e-does-not-handle-binary-requests-as-expected
branch
from
4060931
to
e6a1c32
Compare
nachtjasmin
commented
Jan 19, 2024
nachtjasmin
commented
Jan 19, 2024
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1193-dotnet-e5e-does-not-handle-binary-requests-as-expected
branch
5 times, most recently
from
0a8287a
to
1ff4c15
Compare
|
Could you please also add an example for how to use |
beachmachine
requested changes
Jan 30, 2024
src/Anexia.E5E.Tests/TestData/binary_request_with_multiple_files.json
Outdated
Show resolved
Hide resolved
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1193-dotnet-e5e-does-not-handle-binary-requests-as-expected
branch
from
1ff4c15
to
dcd7967
Compare
nachtjasmin
force-pushed
the
feature/JO-SIANXSVC-1193-dotnet-e5e-does-not-handle-binary-requests-as-expected
branch
from
dcd7967
to
abcdd4b
Compare
beachmachine
approved these changes
Feb 1, 2024
beachmachine
deleted the
feature/JO-SIANXSVC-1193-dotnet-e5e-does-not-handle-binary-requests-as-expected
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SIANXSVC-1193.
This PR introduces a new
E5EFileDataclass for proper serialization and deserialization of files.Old methods were updated to use this new serialization method.
Furthermore, new methods were added to make use of the file deserialization.
Examples got added to the InlineHandler project.