Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIANXSVC-1060: Fix queues not cleaned up after an AMQPWaitTimeoutException #7

Conversation

PatrickTaibel
Copy link
Member

Celery has and requires its own TimeoutException instead of the builtin one to properly clean up py-amqp Consumers.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0762340) 87.33% compared to head (36cd2d1) 87.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   87.33%   87.41%   +0.08%     
==========================================
  Files           3        3              
  Lines         150      151       +1     
==========================================
+ Hits          131      132       +1     
  Misses         19       19              
Files Coverage Δ
celery_amqp_backend/exceptions.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatrickTaibel
Copy link
Member Author

PatrickTaibel commented Oct 24, 2023

I guess the linter and test issues are fixed within #6
EDIT: Fixed with a rebase after the merge of #6

…eption`

Celery has and requires its own TimeoutException instead of the builtin one to properly clean up py-amqp Consumers.
@PatrickTaibel PatrickTaibel force-pushed the ptaibel/SIANXSVC-1060_timeout_clear_queue branch from 833a431 to 36cd2d1 Compare November 2, 2023 08:34
@beachmachine beachmachine merged commit acd43c3 into anexia:main Nov 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants